feat: Hive listener integration #605
Open
+795
−859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
I might have run into stackabletech/hdfs-operator#686 during development. I recognized that I can have an empty string in my discovery configMap from time to time. Behaviour appears to be flaky, but yet more often then not the emtpy string appears: ExpectedFlaky faulty one |
…tackabletech/hive-operator into feat/hive-listener-integration
|
🟢 |
Maleware
moved this from Development: In Progress
to Development: Waiting for Review
in Stackable Engineering
…tackabletech/hive-operator into feat/hive-listener-integration
Co-authored-by: Malte Sander <[email protected]>
…tackabletech/hive-operator into feat/hive-listener-integration
Maleware
moved this from Development: In Review
to Development: In Progress
in Stackable Engineering
maltesander
requested changes
Jun 20, 2025
maltesander
requested changes
Jun 23, 2025
tests/templates/kuttl/kerberos-hdfs/70-install-access-hive.yaml.j2
Outdated
Show resolved
Hide resolved
Comment on lines
+26
to
+32
| --- | ||
| apiVersion: v1 | ||
| kind: Service | ||
| metadata: | ||
| name: test-hive-metastore | ||
| spec: | ||
| type: ClusterIP # cluster-internal |
There was a problem hiding this comment.
Can we test for the metrics service as well?
…l.j2 Co-authored-by: Malte Sander <[email protected]>
Co-authored-by: Nick <[email protected]>
NickLarsenNZ
requested changes
Jun 23, 2025
Comment on lines
+995
to
+998
| // A version value is required, and we do want to use the "recommended" format for the other desired labels | ||
| "none", | ||
| &rolegroup_ref.role, | ||
| &rolegroup_ref.role_group, |
There was a problem hiding this comment.
We would like to add a helper in stackable-operator to produce recommended labels for "role" level things like this.
We should probably also do the same for things that shouldn't be versioned too. Perhaps they can just become Option<T> so that we don't need to add another function.
Leave as is for now, and once that method is available, we can go and update it (before the 25.7 release hopefully).
Comment on lines
+190
to
+192
| fn metastore_default_listener_class() -> String { | ||
| "cluster-internal".to_string() | ||
| } |
There was a problem hiding this comment.
For mine, I used a constant:
pub const DEFAULT_LISTENER_CLASS: &str = "cluster-internal";and
Suggested change
| fn metastore_default_listener_class() -> String { | |
| "cluster-internal".to_string() | |
| } | |
| fn metastore_default_listener_class() -> String { | |
| DEFAULT_LISTENER_CLASS.to_owned() | |
| } |
| #[snafu(display("invalid owner name for discovery ConfigMap"))] | ||
| InvalidOwnerNameForDiscoveryConfigMap, | ||
|
|
||
| #[snafu(display("failed to build Metadata"))] | ||
| MetadataBuild { | ||
| source: stackable_operator::builder::meta::Error, | ||
| }, | ||
| #[snafu(display("{role} listener has no adress"))] | ||
| RoleGroupListenerHasNoAddress { role: String }, |
There was a problem hiding this comment.
Suggested change
| RoleGroupListenerHasNoAddress { role: String }, | |
| RoleListenerHasNoAddress { role: String }, |
There was a problem hiding this comment.
I have added a suggestion to fix its usage below.
| let listener_address = listener_ref | ||
| .status | ||
| .and_then(|s| s.ingress_addresses?.into_iter().next()) | ||
| .context(RoleGroupListenerHasNoAddressSnafu { role })?; |
There was a problem hiding this comment.
Suggested change
| .context(RoleGroupListenerHasNoAddressSnafu { role })?; | |
| .context(RoleListenerHasNoAddressSnafu { role })?; |
Comment on lines
+129
to
+131
| "thrift://{}:{}", | ||
| listener_address.address, | ||
| listener_address |
There was a problem hiding this comment.
We should avoid using unnamed placeholders.
Suggested change
| "thrift://{}:{}", | |
| listener_address.address, | |
| listener_address | |
| "thrift://{address}:{port}", | |
| address = listener_address.address, | |
| port = listener_address |
| @@ -2,4 +2,4 @@ | |||
| apiVersion: kuttl.dev/v1beta1 | |||
| kind: TestAssert | |||
| commands: | |||
| - script: kubectl exec -n $NAMESPACE test-metastore-0 -- python /tmp/test_metastore.py -m hive-metastore-default-0.hive-metastore-default.$NAMESPACE.svc.cluster.local | |||
| - script: kubectl exec -n $NAMESPACE test-metastore-0 -- python /tmp/test_metastore.py -m hive-metastore.$NAMESPACE.svc.cluster.local | |||
There was a problem hiding this comment.
We should be quoting variables used on the CLI as a habit.
Suggested change
| - script: kubectl exec -n $NAMESPACE test-metastore-0 -- python /tmp/test_metastore.py -m hive-metastore.$NAMESPACE.svc.cluster.local | |
| - script: kubectl exec -n "$NAMESPACE" test-metastore-0 -- python /tmp/test_metastore.py -m "hive-metastore.$NAMESPACE.svc.cluster.local" |
But I'm sure we aren't doing that in all the other tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds listener Support
Definition of Done Checklist
Author
Reviewer
Acceptance